Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 12328072: Remove some calls to URLRequestContext::network_delegate(). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Make network_delegate_ a protected member of URLRequestJob. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 0967bd9cc6843d1b2b6ddc946d5b2f935b3ce93a..b2c2650704dfd9346c4c9ce162146b4925820d52 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -1361,8 +1361,8 @@ TEST_F(URLRequestTest, InterceptRespectsCancelInRestart) {
TEST_F(URLRequestTest, Identifiers) {
TestDelegate d;
TestURLRequestContext context;
- TestURLRequest req(GURL("http://example.com"), &d, &context);
- TestURLRequest other_req(GURL("http://example.com"), &d, &context);
+ TestURLRequest req(GURL("http://example.com"), &d, &context, NULL);
+ TestURLRequest other_req(GURL("http://example.com"), &d, &context, NULL);
ASSERT_NE(req.identifier(), other_req.identifier());
}
@@ -3881,7 +3881,7 @@ TEST_F(URLRequestTestHTTP, InterceptPost302RedirectGet) {
req.SetExtraRequestHeaders(headers);
URLRequestRedirectJob* job = new URLRequestRedirectJob(
- &req, default_context_.network_delegate(), test_server_.GetURL("echo"),
+ &req, &default_network_delegate_, test_server_.GetURL("echo"),
URLRequestRedirectJob::REDIRECT_302_FOUND);
AddTestInterceptor()->set_main_intercept_job(job);
@@ -3905,7 +3905,7 @@ TEST_F(URLRequestTestHTTP, InterceptPost307RedirectPost) {
req.SetExtraRequestHeaders(headers);
URLRequestRedirectJob* job = new URLRequestRedirectJob(
- &req, default_context_.network_delegate(), test_server_.GetURL("echo"),
+ &req, &default_network_delegate_, test_server_.GetURL("echo"),
URLRequestRedirectJob::REDIRECT_307_TEMPORARY_REDIRECT);
AddTestInterceptor()->set_main_intercept_job(job);
@@ -4612,7 +4612,7 @@ TEST_F(HTTPSRequestTest, SSLSessionCacheShardTest) {
params.ssl_config_service = default_context_.ssl_config_service();
params.http_auth_handler_factory =
default_context_.http_auth_handler_factory();
- params.network_delegate = default_context_.network_delegate();
+ params.network_delegate = &default_network_delegate_;
params.http_server_properties = default_context_.http_server_properties();
params.ssl_session_cache_shard = "alternate";

Powered by Google App Engine
This is Rietveld 408576698