Remove some calls to URLRequestContext::network_delegate().

net/url_request/url_request_job_factory_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_job_factory_impl.h"
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_job.h"
@@ skipping 42 matching lines @@
     return new MockURLRequestJob(
         request,
         network_delegate,
         URLRequestStatus(URLRequestStatus::SUCCESS, OK));
   }
 };
 
 TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
   TestDelegate delegate;
   TestURLRequestContext request_context;
-  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
+  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context, NULL);
   request.Start();
 
   MessageLoop::current()->Run();
   EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());
   EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().error());
 }
 
 TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
   TestDelegate delegate;
   URLRequestJobFactoryImpl job_factory;
   TestURLRequestContext request_context;
   request_context.set_job_factory(&job_factory);
   job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
-  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
+  TestURLRequest request(GURL("foo://bar"), &delegate, &request_context, NULL);

[mmenke, 2013/03/07 15:45:39]

The TestURLRequestDelegate does have some very basic sanity checking that we
lose by using NULL instead.  Think this is fine in this CL, but it is something
to be aware of in future CLs.

[tedv, 2013/03/07 15:58:32]

My understanding of the code is that TestURLRequestContext gets constructed with
a NULL NetworkDelegate* by default, so I don't believe this loses any sanity
checking.  Unless I missed something in TestURLRequestContext::Init()?

There are other uses of TestURLRequestContexts that use non-NULL network
delegates which I've identified in other pending CLs though.

On 2013/03/07 15:45:39, mmenke wrote:

[mmenke, 2013/03/07 16:05:58]

It gets constructed, but if it's not passed to the URLRequest on construction
(You're passing NULL here), the request won't use it.

   request.Start();
 
   MessageLoop::current()->Run();
   EXPECT_EQ(URLRequestStatus::SUCCESS, request.status().status());
   EXPECT_EQ(OK, request.status().error());
 }
 
 TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
   URLRequestJobFactoryImpl job_factory;
   TestURLRequestContext request_context;
   request_context.set_job_factory(&job_factory);
   job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
   job_factory.SetProtocolHandler("foo", NULL);
 }
 
 }  // namespace
 
 }  // namespace net