Issue 12328029: Plumb HostDesktopType through BrowserListTabContentsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12328029: Plumb HostDesktopType through BrowserListTabContentsProvider. (Closed)

Created:
7 years, 10 months ago by gab

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, vsevik, yurys, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Plumb HostDesktopType through BrowserListTabContentsProvider. Although LaunchDevToolsHandlerIfNeeded (in chrome_browser_main.cc) is the only user via the remote dev tools debugger, the API is rather generic and it made more sense to plumb the HostDesktopType through even if we end up hardcoding it in the only caller. Also removes chrome::NewEmptyWindowDeprecated(). BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184094

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -20 lines)			Patch
M	chrome/browser/browser_process.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/browser_list_tabcontents_provider.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/devtools/browser_list_tabcontents_provider.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/devtools/remote_debugging_server.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/remote_debugging_server.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser_commands.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12328029/1

7 years, 10 months ago (2013-02-22 03:41:29 UTC) #3

Message was sent while issue was closed.

Change committed as 184094

Expand Messages | Collapse Messages