Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2654)

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 12328029: Plumb HostDesktopType through BrowserListTabContentsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc
diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
index 37de019fdd2c09975404bc069da5dd932a6a3c96..f4243a12d0c2b60bf5dfe4109373ee928f9856b7 100644
--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc
+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
@@ -26,8 +26,9 @@ using content::DevToolsHttpHandlerDelegate;
using content::RenderViewHost;
BrowserListTabContentsProvider::BrowserListTabContentsProvider(
- Profile* profile)
- : profile_(profile) {
+ Profile* profile,
+ chrome::HostDesktopType host_desktop_type)
+ : profile_(profile), host_desktop_type_(host_desktop_type) {
}
BrowserListTabContentsProvider::~BrowserListTabContentsProvider() {
@@ -82,13 +83,11 @@ std::string BrowserListTabContentsProvider::GetPageThumbnailData(
}
RenderViewHost* BrowserListTabContentsProvider::CreateNewTarget() {
- // TODO(gab): Do not hardcode HOST_DESKTOP_TYPE_NATIVE below once
- // chrome::NewEmptyWindow() above has been made multi-desktop friendly.
const BrowserList* browser_list =
- BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE);
+ BrowserList::GetInstance(host_desktop_type_);
if (browser_list->empty())
- chrome::NewEmptyWindowDeprecated(profile_);
+ chrome::NewEmptyWindow(profile_, host_desktop_type_);
if (browser_list->empty())
return NULL;
« no previous file with comments | « chrome/browser/devtools/browser_list_tabcontents_provider.h ('k') | chrome/browser/devtools/remote_debugging_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698