Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 12328027: Audio indicator in each tab (Closed)

Created:
4 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Audio indicator in each tab Basically a throbber animation that cycles over a number of frames on a bitmap. Currently only 6 frames, which is too little but good enough for testing. Note that the tab.cc logic should make it so that the audio indicator is low on the priority. That is, if the tab is recording or broadcasting and playing sounds that should show instead of the audio animation. BUG=3541 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184183

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 8 (0 generated)
cpu_(ooo_6.6-7.5)
see the bug for a screenshot.
4 years, 9 months ago (2013-02-21 01:47:17 UTC) #1
sky
https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc File chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (right): https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc#newcode460 chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:460: data->audio_state = TabRendererData::AUDIO_STATE_PLAYING; What gets triggered when the audio ...
4 years, 9 months ago (2013-02-21 01:58:40 UTC) #2
cpu_(ooo_6.6-7.5)
changes made please look again. https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc File chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (right): https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc#newcode460 chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:460: data->audio_state = TabRendererData::AUDIO_STATE_PLAYING; On ...
4 years, 9 months ago (2013-02-21 03:34:51 UTC) #3
sky
LGTM
4 years, 9 months ago (2013-02-21 18:51:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/12328027/5004
4 years, 9 months ago (2013-02-21 19:32:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/12328027/5004
4 years, 9 months ago (2013-02-21 22:21:24 UTC) #6
commit-bot: I haz the power
Change committed as 183977
4 years, 9 months ago (2013-02-22 02:04:27 UTC) #7
cpu_(ooo_6.6-7.5)
4 years, 9 months ago (2013-02-22 21:41:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r184183 (presubmit successful).

Powered by Google App Engine
This is Rietveld efc10ee0f