Audio indicator in each tab

Audio indicator in each tab

Basically a throbber animation that cycles over a number of
frames on a bitmap. Currently only 6 frames, which is too little
but good enough for testing.

Note that the tab.cc logic should make it so that the audio indicator
is low on the priority. That is, if the tab is recording or broadcasting and
playing sounds that should show instead of the audio animation.

BUG=3541
TEST=see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183977
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184183

[cpu_(ooo_6.6-7.5), 2013-02-21 01:47:17]

see the bug for a screenshot.

[sky, 2013-02-21 01:58:40]

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (right):

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:460:
data->audio_state = TabRendererData::AUDIO_STATE_PLAYING;
What gets triggered when the audio state changes so that we end up here?

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:517: 
What's with all these empty lines. Can you nuke 513, 521, 525 and 529.

[cpu_(ooo_6.6-7.5), 2013-02-21 03:34:51]

changes made please look again.

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (right):

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:460:
data->audio_state = TabRendererData::AUDIO_STATE_PLAYING;
On 2013/02/21 01:58:40, sky wrote:
> What gets triggered when the audio state changes so that we end up here?


web_contents->NotifyNavigationStateChanged(content::INVALIDATE_TYPE_TAB);

See https://codereview.chromium.org/11573066/

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:517: 
On 2013/02/21 01:58:40, sky wrote:
> What's with all these empty lines. Can you nuke 513, 521, 525 and 529.

I know, it looked really funky but I was just going with the style of the file
:)

space removed.

[sky, 2013-02-21 18:51:00]

LGTM

[commit-bot: I haz the power, 2013-02-21 19:32:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/12328027/5004

[commit-bot: I haz the power, 2013-02-21 22:21:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/12328027/5004

[commit-bot: I haz the power, 2013-02-22 02:04:27]

Change committed as 183977

[cpu_(ooo_6.6-7.5), 2013-02-22 21:41:59]

Committed patchset #3 manually as r184183 (presubmit successful).