Chromium Code Reviews
Help | Chromium Project | Sign in
(497)

Issue 12328027: Audio indicator in each tab (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by cpu_(out until 23rd)
Modified:
1 year, 1 month ago
Reviewers:
sky
CC:
chromium-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Audio indicator in each tab

Basically a throbber animation that cycles over a number of
frames on a bitmap. Currently only 6 frames, which is too little
but good enough for testing.

Note that the tab.cc logic should make it so that the audio indicator
is low on the priority. That is, if the tab is recording or broadcasting and
playing sounds that should show instead of the audio animation.

BUG=3541
TEST=see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183977
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184183

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -19 lines) Lint Patch
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/views/tabs/tab.h View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 5 chunks +50 lines, -17 lines 0 comments 0 errors Download
M chrome/browser/ui/views/tabs/tab_renderer_data.h View 1 2 2 chunks +8 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/views/tabs/tab_renderer_data.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 8
cpu_(out until 23rd)
see the bug for a screenshot.
1 year, 1 month ago #1
sky
https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc File chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (right): https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc#newcode460 chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:460: data->audio_state = TabRendererData::AUDIO_STATE_PLAYING; What gets triggered when the audio ...
1 year, 1 month ago #2
cpu_(out until 23rd)
changes made please look again. https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc File chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (right): https://codereview.chromium.org/12328027/diff/1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc#newcode460 chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:460: data->audio_state = TabRendererData::AUDIO_STATE_PLAYING; On ...
1 year, 1 month ago #3
sky
LGTM
1 year, 1 month ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/12328027/5004
1 year, 1 month ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/12328027/5004
1 year, 1 month ago #6
I haz the power (commit-bot)
Change committed as 183977
1 year, 1 month ago #7
cpu_(out until 23rd)
1 year, 1 month ago #8
Message was sent while issue was closed.
Committed patchset #3 manually as r184183 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6