Give automation API access to browser plugin objects.

Give automation API access to browser plugin objects.

BUG=488693
Committed: https://crrev.com/73e2f9151f96ca91faa1faf1eb986b5a4fd29ebc
Cr-Commit-Position: refs/heads/master@{#339698}

[dmazzoni, 2015-07-16 18:32:46]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2015-07-16 20:24:24]

lgtm

[dmazzoni, 2015-07-16 21:25:00]

dmazzoni@chromium.org changed reviewers:
+ jam@chromium.org

[dmazzoni, 2015-07-16 21:25:00]

+jam for OWNERS review

[David Tseng, 2015-07-16 22:38:37]

As discussed offline, in order for ChromeVox to work with the OOBE
webview, it needs to be whitelisted for compat:

diff --git
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index 94304e8..d9d148a6 100644
---
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -546,6 +546,7 @@ Background.prototype = {
   isWhitelistedForCompat_: function(url) {
     return url.indexOf('chrome://md-settings') != -1 ||
           url.indexOf('chrome://oobe/login') != -1 ||
+          url.indexOf('https://accounts.google.com/embedded/setup/chromeos') !=
-1 ||
           url === '';
   },
 

dmazzoni@chromium.org writes:

> +jam for OWNERS review
>
>
> https://codereview.chromium.org/1232643003/


To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-07-17 17:34:54]

Thanks for checking that! Could you please just upload that as a one-off
change?

On Thu, Jul 16, 2015 at 3:38 PM, <dtseng@chromium.org> wrote:

> As discussed offline, in order for ChromeVox to work with the OOBE
> webview, it needs to be whitelisted for compat:
>
> diff --git
> a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
> b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
> index 94304e8..d9d148a6 100644
> ---
> a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
> +++
> b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
> @@ -546,6 +546,7 @@ Background.prototype = {
>    isWhitelistedForCompat_: function(url) {
>      return url.indexOf('chrome://md-settings') != -1 ||
>            url.indexOf('chrome://oobe/login') != -1 ||
> +          url.indexOf('
> https://accounts.google.com/embedded/setup/chromeos') != -1 ||
>            url === '';
>    },
>
>
> dmazzoni@chromium.org writes:
>
> > +jam for OWNERS review
> >
> >
> > https://codereview.chromium.org/1232643003/
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2015-07-17 17:39:20]

lgtm

Sounds good; will do.

[jam, 2015-07-20 16:53:34]

lgtm

[dmazzoni, 2015-07-20 16:56:55]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-07-20 16:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232643003/1

[commit-bot: I haz the power, 2015-07-20 17:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 17:17:57]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2015-07-21 17:09:27]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-07-21 17:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1232643003/#ps40001
(title: "Fix compile error")

[commit-bot: I haz the power, 2015-07-21 17:10:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232643003/40001

[commit-bot: I haz the power, 2015-07-21 18:14:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-21 18:16:52]

Patchset 3 (id:??) landed as
https://crrev.com/73e2f9151f96ca91faa1faf1eb986b5a4fd29ebc
Cr-Commit-Position: refs/heads/master@{#339698}