chrome/renderer/resources/extensions/automation/automation_node.js - Issue 1232643003: Give automation API access to browser plugin objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/automation/automation_node.js

Issue 1232643003: Give automation API access to browser plugin objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile error Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/aura/accessibility/automation_manager_aura.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/automation/automation_node.js

diff --git a/chrome/renderer/resources/extensions/automation/automation_node.js b/chrome/renderer/resources/extensions/automation/automation_node.js

index 11ac8d8a3b065b5e292df2df259d81716aa3c95f..5dc6b9b527ff8c4687616bb2910614a9048dace1 100644

--- a/chrome/renderer/resources/extensions/automation/automation_node.js

+++ b/chrome/renderer/resources/extensions/automation/automation_node.js

@@ -779,7 +779,8 @@ AutomationRootNodeImpl.prototype = {

var nodeImpl = privates(node).impl;

// TODO(dtseng): Make into set listing all hosting node roles.

- if (nodeData.role == schema.RoleType.webView) {

+ if (nodeData.role == schema.RoleType.webView ||

+ nodeData.role == schema.RoleType.embeddedObject) {

if (nodeImpl.childTreeID !== nodeData.intAttributes.childTreeId)

nodeImpl.pendingChildFrame = true;