Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 12326167: Merge 143257 (Closed)

Created:
7 years, 9 months ago by pdr.
Modified:
7 years, 9 months ago
Reviewers:
pdr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143257 > Fix scaling of tiled SVG backgrounds on high-dpi displays > https://bugs.webkit.org/show_bug.cgi?id=110047 > > Reviewed by Dirk Schulze. > > Source/WebCore: > > This patch fixes the scaling of SVG when used for drawing patterns. Tiled/patterend SVG > images are first drawn into an image buffer and then the image buffer is used to stamp > out tiles. Because it is a raster source, the size of the image buffer needs to > be scaled to the final resolution of the device. After scaling the image buffer, the > source rect and pattern transforms need to be adjusted so they align in device pixel > coordinates. This adjustment was not done before this patch, causing pixelated rendering. > > Additionally, a FIXME has been added due to webkit.org/b/110065 and the image buffer > has been manually scaled (using "zoomedAndScaledContainerRect") instead of relying > on the ImageBuffer's resolutionScale parameter. > > Test: svg/as-background-image/tiled-background-image.html > > * svg/graphics/SVGImage.cpp: > (WebCore::SVGImage::drawPatternForContainer): > > Note that fixing the FIXME does not change that the source rect and transform need > to be adjusted for page scale. > > LayoutTests: > > * svg/as-background-image/tiled-background-image-expected.html: Added. > * svg/as-background-image/tiled-background-image.html: Added. > TBR=pdr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
A + LayoutTests/svg/as-background-image/tiled-background-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/as-background-image/tiled-background-image-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/svg/graphics/SVGImage.cpp View 1 chunk +17 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pdr.
7 years, 9 months ago (2013-02-27 22:19:41 UTC) #1
pdr.
7 years, 9 months ago (2013-02-27 22:20:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r144238.

Powered by Google App Engine
This is Rietveld 408576698