The first 3 BluetoothTest.* unit tests now running on Mac as well.

Adding class BluetoothTestMac so that the ConstructDefaultAdapter,
ConstructWithoutDefaultAdapter, and ConstructFakeAdapter tests
now pass on Mac as well as Android.

BUG=511008
Committed: https://crrev.com/56d371034c68d9b21150b504138f2d4a2bb4a863
Cr-Commit-Position: refs/heads/master@{#339730}

[krstnmnlsn, 2015-07-16 20:48:28]

Patchset #1 (id:1) has been deleted

[krstnmnlsn, 2015-07-16 23:41:36]

Patchset #1 (id:20001) has been deleted

[krstnmnlsn, 2015-07-16 23:41:42]

Patchset #1 (id:40001) has been deleted

[krstnmnlsn, 2015-07-17 00:01:37]

Patchset #1 (id:60001) has been deleted

[krstnmnlsn, 2015-07-17 01:27:59]

Patchset #1 (id:80001) has been deleted

[krstnmnlsn, 2015-07-17 17:15:48]

krstnmnlsn@chromium.org changed reviewers:
+ scheib@chromium.org

[krstnmnlsn, 2015-07-17 17:15:49]

Adding bluetooth_test_mac!

[scheib, 2015-07-17 21:26:05]

Exciting!

device/bluetooth/bluetooth_device_unittest.cc also has some tests -- they may be
something to bring online in later patches though.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac.h (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac.h:100: //
|low_energy_central_manager_delegate_| as its delegate.  Should be called
'its' is a tad ambiguous. Try "as the manager's delegate".

Should be called only when |IsLowEnergyAvailable()|.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test.h (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test.h:16: const std::string kTestAdapterName =
"FakeBluetoothAdapter";
Probably we should move these to be static members of BluetoothTestBase.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_mac.h (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_mac.h:31:
scoped_refptr<base::TestSimpleTaskRunner> ui_task_runner_;
Instead, can BluetoothTestBase::message_loop_.task_runner() be used?

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_mac.mm (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_mac.mm:20:
BluetoothAdapterMac::CreateAdapterForTest("", "", ui_task_runner_).get();
The intent of "InitWithDefaultAdapter" is to create the BluetoothAdapterMac
using the 'real' adapter from the OS. Either we can get away with
CreateAdapter(), or we should omit tests that use this method on Mac for now.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_mac.mm:28: adapter_mac_ =
static_cast<BluetoothAdapterMac*>(adapter_.get());
Seems silly to static_cast. Have CreateAdapterForTest return a
BluetoothAdapterMac, and then also assign to adapter_.

[krstnmnlsn, 2015-07-17 23:14:50]

donedonedone :)

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac.h (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac.h:100: //
|low_energy_central_manager_delegate_| as its delegate.  Should be called
On 2015/07/17 21:26:04, scheib wrote:
> 'its' is a tad ambiguous. Try "as the manager's delegate".
> 
> Should be called only when |IsLowEnergyAvailable()|.

Done.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test.h (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test.h:16: const std::string kTestAdapterName =
"FakeBluetoothAdapter";
On 2015/07/17 21:26:04, scheib wrote:
> Probably we should move these to be static members of BluetoothTestBase.

Done.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_mac.h (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_mac.h:31:
scoped_refptr<base::TestSimpleTaskRunner> ui_task_runner_;
On 2015/07/17 21:26:05, scheib wrote:
> Instead, can BluetoothTestBase::message_loop_.task_runner() be used?

Done.

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_mac.mm (right):

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_mac.mm:20:
BluetoothAdapterMac::CreateAdapterForTest("", "", ui_task_runner_).get();
On 2015/07/17 21:26:05, scheib wrote:
> The intent of "InitWithDefaultAdapter" is to create the BluetoothAdapterMac
> using the 'real' adapter from the OS. Either we can get away with
> CreateAdapter(), or we should omit tests that use this method on Mac for now.

So for some reason I thought there was a problem when I called
base::ThreadTaskRunnerHandle::Get() during the test, but that doesn't seem to be
the case.  So sure, using the authentic CreateAdapter(); now.  (technically the
underlying OS adapter / CBCentralManager is the same whether we call
CreateAdapter() or CreateAdapterForTest(), SetManagerForTesting() is where it
gets swapped out for a fake, but I might refactor that in the future...).

https://codereview.chromium.org/1232613004/diff/90001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_mac.mm:28: adapter_mac_ =
static_cast<BluetoothAdapterMac*>(adapter_.get());
On 2015/07/17 21:26:05, scheib wrote:
> Seems silly to static_cast. Have CreateAdapterForTest return a
> BluetoothAdapterMac, and then also assign to adapter_.

Done.

[scheib, 2015-07-19 19:41:44]

LGTM with 1 more change:

https://codereview.chromium.org/1232613004/diff/110001/device/bluetooth/test/...
File device/bluetooth/test/bluetooth_test_mac.mm (right):

https://codereview.chromium.org/1232613004/diff/110001/device/bluetooth/test/...
device/bluetooth/test/bluetooth_test_mac.mm:19: adapter_mac_ =
static_cast<BluetoothAdapterMac*>(adapter_.get());
Please change the type for CreateAdapter() too, so that this static cast is also
not needed.

[krstnmnlsn, 2015-07-20 18:11:23]

krstnmnlsn@chromium.org changed reviewers:
+ armansito@chromium.org

[krstnmnlsn, 2015-07-20 18:11:24]

Thanks Vincent :)

Hey Arman, could you please review this and the previous patch it depends on.

Thank you!

https://codereview.chromium.org/1232613004/diff/110001/device/bluetooth/test/...
File device/bluetooth/test/bluetooth_test_mac.mm (right):

https://codereview.chromium.org/1232613004/diff/110001/device/bluetooth/test/...
device/bluetooth/test/bluetooth_test_mac.mm:19: adapter_mac_ =
static_cast<BluetoothAdapterMac*>(adapter_.get());
On 2015/07/19 19:41:44, scheib wrote:
> Please change the type for CreateAdapter() too, so that this static cast is
also
> not needed.

Done.

[armansito, 2015-07-21 02:26:48]

lgtm

[krstnmnlsn, 2015-07-21 18:01:32]

The CQ bit was checked by krstnmnlsn@chromium.org

[krstnmnlsn, 2015-07-21 18:01:33]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
armansito@chromium.org
Link to the patchset: https://codereview.chromium.org/1232613004/#ps170001
(title: "comment edit")

[commit-bot: I haz the power, 2015-07-21 18:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 18:03:58]

This CL has an open dependency (Issue 1226133006 Patch 140001). Please resolve
the dependency and try again.

[krstnmnlsn, 2015-07-21 19:22:25]

The CQ bit was checked by krstnmnlsn@chromium.org

[commit-bot: I haz the power, 2015-07-21 19:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232613004/170001

[krstnmnlsn, 2015-07-21 20:05:16]

The CQ bit was unchecked by krstnmnlsn@chromium.org

[krstnmnlsn, 2015-07-21 20:05:17]

The CQ bit was checked by krstnmnlsn@chromium.org

[commit-bot: I haz the power, 2015-07-21 20:05:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232613004/170001

[commit-bot: I haz the power, 2015-07-21 20:18:17]

Committed patchset #5 (id:170001)

[commit-bot: I haz the power, 2015-07-21 20:19:31]

Patchset 5 (id:??) landed as
https://crrev.com/56d371034c68d9b21150b504138f2d4a2bb4a863
Cr-Commit-Position: refs/heads/master@{#339730}