Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1226133006: Move CBCentralManager from the Discovery Manager to Adapter (Closed)

Created:
5 years, 5 months ago by krstnmnlsn
Modified:
5 years, 5 months ago
Reviewers:
scheib, armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@adddevs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CBCentralManager from the Discovery Manager to Adapter Giving BluetoothAdapterMac ownership of the CBCentralManager (the discovery manager retains a pointer) and separating the CBCentralManagerDelegate class from the BluetoothLowEnergyDiscoveryManagerMac file, as it will soon support non- discovery callbacks from CoreBluetooth as well. BUG=510491 Committed: https://crrev.com/b79157aa7623512c5384eab60e11d3f538bdecdc Cr-Commit-Position: refs/heads/master@{#339701}

Patch Set 1 : pulling in origin/master #

Patch Set 2 : comment edit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -102 lines) Patch
M device/bluetooth/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 1 5 chunks +16 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 4 chunks +26 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_mac_unittest.mm View 1 2 chunks +2 lines, -3 lines 0 comments Download
A device/bluetooth/bluetooth_low_energy_central_manager_delegate.h View 1 chunk +37 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_low_energy_central_manager_delegate.mm View 1 chunk +68 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_discovery_manager_mac.h View 4 chunks +5 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm View 4 chunks +10 lines, -80 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
krstnmnlsn
So here's the change I was thinking of making. Basically the central manager currently belongs ...
5 years, 5 months ago (2015-07-15 17:22:28 UTC) #2
scheib
LGTM
5 years, 5 months ago (2015-07-15 20:17:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226133006/1
5 years, 5 months ago (2015-07-15 20:23:34 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/73804) ios_dbg_simulator_ninja on ...
5 years, 5 months ago (2015-07-15 20:29:02 UTC) #7
krstnmnlsn
Hey Arman, here's a refactoring change. Please review when you get a chance :)
5 years, 5 months ago (2015-07-17 17:05:38 UTC) #15
armansito
lgtm
5 years, 5 months ago (2015-07-21 02:24:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226133006/140001
5 years, 5 months ago (2015-07-21 17:14:51 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:140001)
5 years, 5 months ago (2015-07-21 18:19:30 UTC) #20
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 18:22:13 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b79157aa7623512c5384eab60e11d3f538bdecdc
Cr-Commit-Position: refs/heads/master@{#339701}

Powered by Google App Engine
This is Rietveld 408576698