Third Party authentication protocol.

remoting/protocol/authentication_method.h

Index: remoting/protocol/authentication_method.h
diff --git a/remoting/protocol/authentication_method.h b/remoting/protocol/authentication_method.h
index 95a27e07a10c48e646640ca089d0e215e4ae1c9f..ed11c4e802db34154acf6593e0bedf3cfb9c7331 100644
--- a/remoting/protocol/authentication_method.h
+++ b/remoting/protocol/authentication_method.h
@@ -29,6 +29,7 @@ class AuthenticationMethod {
   // Constructors for various authentication methods.
   static AuthenticationMethod Invalid();
   static AuthenticationMethod Spake2(HashFunction hash_function);
+  static AuthenticationMethod ThirdParty();
 
   // Parses a string that defines an authentication method. Returns an
   // invalid value if the string is invalid.
@@ -43,6 +44,9 @@ class AuthenticationMethod {
   // Returns true
   bool is_valid() const { return !invalid_; }
 
+  // Returns true
+  bool requires_token() const { return requires_token_; }
+
   // Following methods are valid only when is_valid() returns true.
 
   // Hash function applied to the shared secret on both ends.
@@ -58,11 +62,13 @@ class AuthenticationMethod {
     return !(*this == other);
   }
 
- private:
+ protected:

[Sergey Ulanov, 2013/03/20 07:24:12]

why?

[rmsousa, 2013/03/21 01:23:25]

Likely some early design leftover.

   AuthenticationMethod();
-  explicit AuthenticationMethod(HashFunction hash_function);
+  explicit AuthenticationMethod(HashFunction hash_function,
+                                bool requires_token);
 
   bool invalid_;
+  bool requires_token_;

[Sergey Ulanov, 2013/03/20 07:24:12]

Doesn't look like a good name. I suggest that instead of adding another boolean
member here you add "enum Type" with three values (INVALID, SPAKE, THIRD_PARTY)
and then you wouldn't need invalid_

[rmsousa, 2013/03/21 01:23:25]

Done.

   HashFunction hash_function_;
 };