Third Party authentication protocol.

remoting/protocol/authentication_method.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // AuthenticationMethod represents an authentication algorithm and its
 // configuration. It knows how to parse and format authentication
 // method names.
 // Currently the following methods are supported:
 //   spake2_plain - SPAKE2 without hashing applied to the password.
 //   spake2_hmac - SPAKE2 with HMAC hashing of the password.
@@ skipping 11 matching lines @@
 class AuthenticationMethod {
  public:
   enum HashFunction {
     NONE,
     HMAC_SHA256,
   };
 
   // Constructors for various authentication methods.
   static AuthenticationMethod Invalid();
   static AuthenticationMethod Spake2(HashFunction hash_function);
+  static AuthenticationMethod ThirdParty();
 
   // Parses a string that defines an authentication method. Returns an
   // invalid value if the string is invalid.
   static AuthenticationMethod FromString(const std::string& value);
 
   // Applies the specified hash function to |shared_secret| with the
   // specified |tag| as a key.
   static std::string ApplyHashFunction(HashFunction hash_function,
                                        const std::string& tag,
                                        const std::string& shared_secret);
 
   // Returns true
   bool is_valid() const { return !invalid_; }
 
+  // Returns true
+  bool requires_token() const { return requires_token_; }
+
   // Following methods are valid only when is_valid() returns true.
 
   // Hash function applied to the shared secret on both ends.
   HashFunction hash_function() const;
 
   // Returns string representation of the value stored in this object.
   const std::string ToString() const;
 
   // Comparison operators so that std::find() can be used with
   // collections of this class.
   bool operator ==(const AuthenticationMethod& other) const;
   bool operator !=(const AuthenticationMethod& other) const {
     return !(*this == other);
   }
 
- private:
+ protected:

[Sergey Ulanov, 2013/03/20 07:24:12]

why?

[rmsousa, 2013/03/21 01:23:25]

Likely some early design leftover.

   AuthenticationMethod();
-  explicit AuthenticationMethod(HashFunction hash_function);
+  explicit AuthenticationMethod(HashFunction hash_function,
+                                bool requires_token);
 
   bool invalid_;
+  bool requires_token_;

[Sergey Ulanov, 2013/03/20 07:24:12]

Doesn't look like a good name. I suggest that instead of adding another boolean
member here you add "enum Type" with three values (INVALID, SPAKE, THIRD_PARTY)
and then you wouldn't need invalid_

[rmsousa, 2013/03/21 01:23:25]

Done.

   HashFunction hash_function_;
 };
 
 // SharedSecretHash stores hash of a host secret paired with the type
 // of the hashing function.
 struct SharedSecretHash {
   AuthenticationMethod::HashFunction hash_function;
   std::string value;
 
   // Parse string representation of a shared secret hash. The |as_string|
   // must be in form "<hash_function>:<hash_value_base64>".
   bool Parse(const std::string& as_string);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_AUTHENTICATION_METHOD_H_