Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 12326083: Merge 143512 (Closed)

Created:
7 years, 10 months ago by dgrogan
Modified:
7 years, 10 months ago
Reviewers:
dgrogan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143512 > IndexedDB: Limit LevelDB's max open files > https://bugs.webkit.org/show_bug.cgi?id=109993 > > Reviewed by Tony Chang. > > LevelDB keeps up to 1000 (by default) data files open at a time to > avoid having to open() them. This has caused chromium to hit the > process-wide open file limit. This patch changes max_open_files to 20, > as that's the minimum permitted by LevelDB and we have no reason to > think that performance will suffer because of the extra open calls. > > No new tests - a chromium browser test that tracks the open LevelDB > files is plausible but is blocked on http://crbug.com/177249/. > > * platform/leveldb/LevelDBDatabase.cpp: > (WebCore::openDB): > TBR=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/WebCore/platform/leveldb/LevelDBDatabase.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dgrogan
7 years, 10 months ago (2013-02-22 22:17:37 UTC) #1
dgrogan
7 years, 10 months ago (2013-02-22 22:17:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143798.

Powered by Google App Engine
This is Rietveld 408576698