extensions/browser/browser_context_keyed_api_factory.h - Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/browser_context_keyed_api_factory.h

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment by kalman@. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/rules_registry_service.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/browser_context_keyed_api_factory.h

diff --git a/extensions/browser/browser_context_keyed_api_factory.h b/extensions/browser/browser_context_keyed_api_factory.h

index fc0add240e066d5b81ea510ee7b1d2e4d44872b4..ad87e22d84b0754f0c23b46d36380ecea9dcf325 100644

--- a/extensions/browser/browser_context_keyed_api_factory.h

+++ b/extensions/browser/browser_context_keyed_api_factory.h

@@ -76,6 +76,11 @@ class BrowserContextKeyedAPIFactory : public BrowserContextKeyedServiceFactory {

T::GetFactoryInstance()->GetServiceForBrowserContext(context, true));

}

+ static T* GetIfExists(content::BrowserContext* context) {

+ return static_cast<T*>(

+ T::GetFactoryInstance()->GetServiceForBrowserContext(context, false));

+ }

// Declare dependencies on other factories.

// By default, ExtensionSystemFactory is the only dependency; however,

// specializations can override this. Declare your specialization in