extensions/browser/api/declarative/rules_registry_service.cc - Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry_service.cc

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment by kalman@. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/rules_registry_service.h ('k') | extensions/browser/browser_context_keyed_api_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/rules_registry_service.cc

diff --git a/extensions/browser/api/declarative/rules_registry_service.cc b/extensions/browser/api/declarative/rules_registry_service.cc

index 939b01eab2ae33b92bdf779c059582e6ae5ee6ab..bca6fd5bb2dbba2156c2b1dfc8abf93a4f53cec3 100644

--- a/extensions/browser/api/declarative/rules_registry_service.cc

+++ b/extensions/browser/api/declarative/rules_registry_service.cc

@@ -137,6 +137,13 @@ RulesRegistryService* RulesRegistryService::Get(

return BrowserContextKeyedAPIFactory<RulesRegistryService>::Get(context);

}

+// static

+RulesRegistryService* RulesRegistryService::GetIfExists(

+ content::BrowserContext* context) {

+ return BrowserContextKeyedAPIFactory<RulesRegistryService>::GetIfExists(

+ context);

void RulesRegistryService::RegisterRulesRegistry(

scoped_refptr<RulesRegistry> rule_registry) {

const std::string event_name(rule_registry->event_name());