extensions/browser/api/declarative/rules_registry_service.h - Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry_service.h

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for failing tests. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/test_guest_view_manager.cc ('k') | extensions/browser/api/declarative/rules_registry_service.cc » ('j') | extensions/browser/browser_context_keyed_api_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/rules_registry_service.h

diff --git a/extensions/browser/api/declarative/rules_registry_service.h b/extensions/browser/api/declarative/rules_registry_service.h

index f03adbad7f5b3f1ade92989e3b8879e86e7d0e32..3f9113813a96329eb25d9c24c4d4cbb328fc1521 100644

--- a/extensions/browser/api/declarative/rules_registry_service.h

+++ b/extensions/browser/api/declarative/rules_registry_service.h

@@ -61,8 +61,13 @@ class RulesRegistryService : public BrowserContextKeyedAPI,

static BrowserContextKeyedAPIFactory<RulesRegistryService>*

GetFactoryInstance();

- // Convenience method to get the RulesRegistryService for a context.

+ // Convenience method to get the RulesRegistryService for a context. If

+ // |create| is provided, it specifies whether a new RulesRegistryService

+ // should be created if one does not already exist (true if omitted). If

+ // |create| is false and one does not already exist, nullptr will be returned.

static RulesRegistryService* Get(content::BrowserContext* context);

+ static RulesRegistryService* Get(content::BrowserContext* context,

+ bool create);

int GetNextRulesRegistryID();