components/guest_view/browser/test_guest_view_manager.cc - Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/test_guest_view_manager.cc

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for failing tests. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/test_guest_view_manager.h ('k') | extensions/browser/api/declarative/rules_registry_service.h » ('j') | extensions/browser/browser_context_keyed_api_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/test_guest_view_manager.cc

diff --git a/components/guest_view/browser/test_guest_view_manager.cc b/components/guest_view/browser/test_guest_view_manager.cc

index 78458ef1d6c8fb4f12eac78fa3c1af5d3647afca..d80eb0d10c9da8ba1d82235851baa4e59c4d10a6 100644

--- a/components/guest_view/browser/test_guest_view_manager.cc

+++ b/components/guest_view/browser/test_guest_view_manager.cc

@@ -95,9 +95,9 @@ void TestGuestViewManager::RemoveGuest(int guest_instance_id) {

GuestViewManager::RemoveGuest(guest_instance_id);

}

-void TestGuestViewManager::EmbedderWillBeDestroyed(int embedder_process_id) {

+void TestGuestViewManager::EmbedderProcessDestroyed(int embedder_process_id) {

++num_embedder_processes_destroyed_;

- GuestViewManager::EmbedderWillBeDestroyed(embedder_process_id);

+ GuestViewManager::EmbedderProcessDestroyed(embedder_process_id);

}

void TestGuestViewManager::ViewGarbageCollected(int embedder_process_id,