mac content shell drt: Do not force the mesa gl implementation.

Closed in favor of https://codereview.chromium.org/12315103/



mac content shell drt: Do not force the mesa gl implementation.

image_transport_surface_mac.cc's ImageTransportSurface::CreateSurface() only
works for DesktopGL and AppleGL, and that function is used for drawing
that uses the gpu process.

osmesa was added in https://codereview.chromium.org/11143009, but sadly
the CL description doesn't say why.

BUG=111316
TEST=animations/3d/change-transform-in-end-event.html has only minor
text-antialiasing related pixel errors when running locally, instead
of timing out.

[Nico, 2013-02-20 16:05:52]

https://codereview.chromium.org/12326013/diff/1/content/shell/shell_main_dele...
File content/shell/shell_main_delegate.cc (right):

https://codereview.chromium.org/12326013/diff/1/content/shell/shell_main_dele...
content/shell/shell_main_delegate.cc:102: switches::kUseGL,
gfx::kGLImplementationOSMesaName);
If you remember why you added this, I can add a comment.

[jochen (gone - plz use gerrit), 2013-02-20 16:10:48]

layout tests need to run with osmesa

The webgl tests differ a lot depending on what hardware you run them on :-/

[Nico, 2013-02-20 16:12:47]

The gpu process doesn't work on mac with osmesa.

On Wed, Feb 20, 2013 at 5:10 PM,  <jochen@chromium.org> wrote:
> layout tests need to run with osmesa
>
> The webgl tests differ a lot depending on what hardware you run them on :-/
>
> https://codereview.chromium.org/12326013/

[Nico, 2013-02-20 16:19:57]

Offscreen discussion: osmesa does software painting in-process in the
renderer, so I'll try to not create transport surfaces in test shell
when in drt mode instead.

On Wed, Feb 20, 2013 at 5:12 PM, Nico Weber <thakis@chromium.org> wrote:
> The gpu process doesn't work on mac with osmesa.
>
> On Wed, Feb 20, 2013 at 5:10 PM,  <jochen@chromium.org> wrote:
>> layout tests need to run with osmesa
>>
>> The webgl tests differ a lot depending on what hardware you run them on :-/
>>
>> https://codereview.chromium.org/12326013/

[Ken Russell (switch to Gerrit), 2013-02-26 20:25:29]

LGTM if this works.

I don't remember off the top of my head which bots are expected to run which
configurations, but I recall senorblanco adding support for Apple's software GL
rather than Mesa for testing purposes some time ago.

https://codereview.chromium.org/12326013/diff/1/content/common/gpu/image_tran...
File content/common/gpu/image_transport_surface_mac.cc (right):

https://codereview.chromium.org/12326013/diff/1/content/common/gpu/image_tran...
content/common/gpu/image_transport_surface_mac.cc:439: NOTREACHED() <<
gfx::GetGLImplementation();
This could be more descriptive.

[zmo, 2013-02-26 20:35:17]

LGTM

https://codereview.chromium.org/12326013/diff/1/content/shell/shell_main_dele...
File content/shell/shell_main_delegate.cc (right):

https://codereview.chromium.org/12326013/diff/1/content/shell/shell_main_dele...
content/shell/shell_main_delegate.cc:102: switches::kUseGL,
gfx::kGLImplementationOSMesaName);
On 2013/02/20 16:05:52, Nico wrote:
> If you remember why you added this, I can add a comment.

OSMesa support on Mac is incomplete, that's why we don't use it on Mac.

[Nico, 2013-02-26 20:38:20]

Sorry, I sent the wrong link, I meant to send out
https://codereview.chromium.org/12315103/ which does use osmesa on mac
and adds simple surface transport. It seems to work in practice, while
this CL here broke a few of the webgl layout tests (which test
extension strings and whatnot).

On Tue, Feb 26, 2013 at 9:35 PM,  <zmo@google.com> wrote:
> LGTM
>
>
>
>
https://codereview.chromium.org/12326013/diff/1/content/shell/shell_main_dele...
> File content/shell/shell_main_delegate.cc (right):
>
>
https://codereview.chromium.org/12326013/diff/1/content/shell/shell_main_dele...
> content/shell/shell_main_delegate.cc:102: switches::kUseGL,
> gfx::kGLImplementationOSMesaName);
> On 2013/02/20 16:05:52, Nico wrote:
>>
>> If you remember why you added this, I can add a comment.
>
>
> OSMesa support on Mac is incomplete, that's why we don't use it on Mac.
>
> https://codereview.chromium.org/12326013/