Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1232573007: Added tool to call tools in infra.git (Closed)

Created:
5 years, 5 months ago by hinoka
Modified:
5 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added tool to call tools in infra.git Example usage: yo cq_stats --help BUG= R=stip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=296053

Patch Set 1 #

Total comments: 6

Patch Set 2 : Renamed to yoo #

Patch Set 3 : Added usage string #

Patch Set 4 : yoo -> cit #

Patch Set 5 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -13 lines) Patch
A + cit View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + cit.bat View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
A cit.py View 1 2 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
ghost stip (do not use)
In general I'm OK with this. I'd like the checkout location to be more explicit, ...
5 years, 5 months ago (2015-07-11 00:44:47 UTC) #2
Ryan Tseng
https://codereview.chromium.org/1232573007/diff/1/yo File yo (right): https://codereview.chromium.org/1232573007/diff/1/yo#newcode1 yo:1: #!/usr/bin/env bash On 2015/07/11 00:44:47, stip wrote: > suggestion: ...
5 years, 5 months ago (2015-07-11 05:43:35 UTC) #4
hinoka
Comments addressed, also added usage string. https://codereview.chromium.org/1232573007/diff/1/cit.py File cit.py (right): https://codereview.chromium.org/1232573007/diff/1/cit.py#newcode22 cit.py:22: THIS_DIR = os.path.dirname(os.path.abspath(__file__)) ...
5 years, 5 months ago (2015-07-14 18:51:36 UTC) #5
M-A Ruel
I'm a bit confused. Why would people want to call into infra.git? It's to transition ...
5 years, 5 months ago (2015-07-14 19:56:05 UTC) #6
hinoka
Because we now have user tools in infra.git. Short discussion here: https://chromereviews.googleplex.com/223127013/ Also yoo -> ...
5 years, 5 months ago (2015-07-14 20:17:14 UTC) #7
ghost stip (do not use)
lgtm https://www.youtube.com/watch?v=gjVmeKWOsEU
5 years, 5 months ago (2015-07-16 00:56:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232573007/60001
5 years, 5 months ago (2015-07-16 00:57:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/122)
5 years, 5 months ago (2015-07-16 01:01:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232573007/80001
5 years, 5 months ago (2015-07-17 21:57:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/125)
5 years, 5 months ago (2015-07-17 21:59:53 UTC) #17
hinoka
5 years, 5 months ago (2015-07-17 22:05:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 296053.

Powered by Google App Engine
This is Rietveld 408576698