Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: include/xml/SkXMLWriter.h

Issue 1232463006: Fix up -Winconsistent-missing-override (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: llvm_coverage_build Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/simpleaaclip.cpp ('k') | samplecode/SampleApp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/xml/SkXMLWriter.h
diff --git a/include/xml/SkXMLWriter.h b/include/xml/SkXMLWriter.h
index 45356d488f856ee934bd086ffb6d18088d39a6d2..4c0935fc219ffa7d0527d724be5810eafd558642 100644
--- a/include/xml/SkXMLWriter.h
+++ b/include/xml/SkXMLWriter.h
@@ -65,7 +65,7 @@ class SkXMLStreamWriter : public SkXMLWriter {
public:
SkXMLStreamWriter(SkWStream*);
virtual ~SkXMLStreamWriter();
- virtual void writeHeader();
+ void writeHeader() override;
SkDEBUGCODE(static void UnitTest();)
protected:
@@ -83,10 +83,10 @@ public:
SkXMLParserWriter(SkXMLParser*);
virtual ~SkXMLParserWriter();
protected:
- virtual void onStartElementLen(const char elem[], size_t length);
- virtual void onEndElement();
- virtual void onAddAttributeLen(const char name[], const char value[], size_t length);
- virtual void onAddText(const char text[], size_t length) override;
+ void onStartElementLen(const char elem[], size_t length) override;
+ void onEndElement() override;
+ void onAddAttributeLen(const char name[], const char value[], size_t length) override;
+ void onAddText(const char text[], size_t length) override;
private:
SkXMLParser& fParser;
};
« no previous file with comments | « gm/simpleaaclip.cpp ('k') | samplecode/SampleApp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698