Use entry rather than index in ElementsAccessor::Set

Use entry rather than index in ElementsAccessor::Set

BUG=v8:4137, v8:4177
LOG=n

Committed: https://crrev.com/f87af94a4670455e798db8a22d55aea43ed11a96
Cr-Commit-Position: refs/heads/master@{#29571}

[Toon Verwaest, 2015-07-10 11:24:04]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-07-10 11:24:05]

ptal

[Igor Sheludko, 2015-07-10 11:56:42]

lgtm with nits:

https://codereview.chromium.org/1232463005/diff/1/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1232463005/diff/1/src/elements.cc#newcode1552
src/elements.cc:1552: return ArgumentsAccessor::GetDetailsImpl(arguments,
entry);
While you are here, please call this like
  ArgumentsAccessor::GetDetailsImpl(arguments, entry - length);

to be uniform with other places.

https://codereview.chromium.org/1232463005/diff/1/src/elements.cc#newcode1689
src/elements.cc:1689: FastHoleyObjectElementsAccessor::SetImpl(arguments, index,
*value);
For better readability, please convert index to entry before passing it to
SetImpl() even it's a no-op.

[Toon Verwaest, 2015-07-10 12:32:05]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-07-10 12:32:06]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1232463005/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2015-07-10 12:32:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232463005/20001

[commit-bot: I haz the power, 2015-07-10 12:56:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-10 12:56:50]

Patchset 2 (id:??) landed as
https://crrev.com/f87af94a4670455e798db8a22d55aea43ed11a96
Cr-Commit-Position: refs/heads/master@{#29571}