src/lookup.cc - Issue 1232463005: Use entry rather than index in ElementsAccessor::Set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 1232463005: Use entry rather than index in ElementsAccessor::Set (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index be18b3b7a182f010a177b875ab000002d4b8a31a..a52e9afa7c35aa7b4b846fdb7da5edf083a633fb 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -414,7 +414,7 @@ void LookupIterator::WriteDataValue(Handle<Object> value) {

Handle<JSObject> holder = GetHolder<JSObject>();

if (IsElement()) {

ElementsAccessor* accessor = holder->GetElementsAccessor();

- accessor->Set(holder->elements(), index_, *value);

+ accessor->Set(holder->elements(), number_, *value);

} else if (holder->IsGlobalObject()) {

Handle<GlobalDictionary> property_dictionary =

handle(holder->global_dictionary());

« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »