Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tests/compiler/dart2js_extra/23828_test.dart

Issue 1232423004: dart2js: check for the full getter/setter prefixes (fix #23828) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js_extra/23828_test.dart
diff --git a/tests/language/final_super_field_set_test.dart b/tests/compiler/dart2js_extra/23828_test.dart
similarity index 50%
copy from tests/language/final_super_field_set_test.dart
copy to tests/compiler/dart2js_extra/23828_test.dart
index 9c3289bb1f94059cdc49e5330bfad14bb4f58d3f..b6312a3901cf9b3233e03d3bffb6535a3d36dae2 100644
--- a/tests/language/final_super_field_set_test.dart
+++ b/tests/compiler/dart2js_extra/23828_test.dart
@@ -2,19 +2,16 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// Regression test for http://dartbug.com/23828/
+// Used to fail when methods contain a name starting with `get`
import 'package:expect/expect.dart';
-class SuperClass {
- final field = 0;
- noSuchMethod(_) => 42;
-}
+confuse(x) { return x; return x; }
-class Class extends SuperClass {
- m() {
- super.field = 87; /// 01: static type warning
- }
+class MA {
+ noSuchMethod(i) => Expect.equals(i.positionalArguments.length, 1);
}
main() {
- new Class().m(); /// 01: continued
-}
+ confuse(new MA()).getFoo('a');
+}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698