pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart - Issue 1232423004: dart2js: check for the full getter/setter prefixes (fix #23828)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

Issue 1232423004: dart2js: check for the full getter/setter prefixes (fix #23828) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

index 7aa34bd7bae0f65e2fa1f9e0d65036902f116a3c..cf823c1d15b2cd08a6653395696b3fbb94658e7b 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

@@ -237,8 +237,8 @@ class NsmEmitter extends CodeEmitterHelper {

for (var j = 0; j < shortNames.length; j++) {

var type = 0;

var shortName = shortNames[j];

- if (shortName[0] == "${namer.getterPrefix[0]}") type = 1;

- if (shortName[0] == "${namer.setterPrefix[0]}") type = 2;

+ if (shortName.indexOf("${namer.getterPrefix}") == 0) type = 1;

+ if (shortName.indexOf("${namer.setterPrefix}") == 0) type = 2;

// Generate call to:

// createInvocationMirror(String name, internalName, type,

« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/23828_test.dart » ('j') | no next file with comments »