Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1232403003: Removing UIEvent.keyCode and charCode. (Closed)

Created:
5 years, 5 months ago by Paritosh Kumar
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -36 lines) Patch
M LayoutTests/fast/events/init-events-expected.txt View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/events/script-tests/init-events.js View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/UIEvent.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/events/UIEvent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/events/UIEvent.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 5 months ago (2015-07-13 12:44:35 UTC) #2
philipj_slow
Looks good, but the thread on blink-dev is still missing two L-G-T-Ms. https://codereview.chromium.org/1232403003/diff/40001/LayoutTests/fast/events/script-tests/init-events.js File LayoutTests/fast/events/script-tests/init-events.js ...
5 years, 5 months ago (2015-07-13 13:58:59 UTC) #3
Paritosh Kumar
Thanks Philip, Removed tests of keyCode/charCode for non-KeyboardEvents. And We have 3 L-G-T-Ms on intent ...
5 years, 5 months ago (2015-07-16 07:53:47 UTC) #4
philipj_slow
lgtm I edited the description slightly to not have such a long line.
5 years, 5 months ago (2015-07-16 08:02:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232403003/60001
5 years, 5 months ago (2015-07-16 08:03:03 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 09:06:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199019

Powered by Google App Engine
This is Rietveld 408576698