Source/core/events/KeyboardEvent.h - Issue 1232403003: Removing UIEvent.keyCode and charCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/KeyboardEvent.h

Issue 1232403003: Removing UIEvent.keyCode and charCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/events/KeyboardEvent.h

diff --git a/Source/core/events/KeyboardEvent.h b/Source/core/events/KeyboardEvent.h

index 07f3430366f1a72538f7887da537ad931cc3703b..5080f2b2c37563b51930997f0b9744063ae60d23 100644

--- a/Source/core/events/KeyboardEvent.h

+++ b/Source/core/events/KeyboardEvent.h

@@ -80,8 +80,8 @@ public:

const PlatformKeyboardEvent* keyEvent() const { return m_keyEvent.get(); }

- int keyCode() const override; // key code for keydown and keyup, character for keypress

- int charCode() const override; // character code for keypress, 0 for keydown and keyup

+ int keyCode() const; // key code for keydown and keyup, character for keypress

+ int charCode() const; // character code for keypress, 0 for keydown and keyup

bool repeat() const { return m_isAutoRepeat; }

const AtomicString& interfaceName() const override;