Android buildbot - halt build if subcommand returns error

buildbot/bb_run_bot.py

Index: buildbot/bb_run_bot.py
===================================================================
--- buildbot/bb_run_bot.py	(revision 183435)
+++ buildbot/bb_run_bot.py	(working copy)
@@ -178,7 +178,6 @@
   for command_obj in command_objs:
     print 'Will run:', CommandToString(command_obj.command)
 
-  return_code = 0
   for command_obj in command_objs:
     if command_obj.step_name:
       buildbot_report.PrintNamedStep(command_obj.step_name)
@@ -193,8 +192,9 @@
       env = dict(os.environ)
       env['BUILDBOT_TESTING'] = '1'
 
-    return_code |= subprocess.call(command, cwd=CHROME_SRC, env=env)
-  return return_code
+    return_code = subprocess.call(command, cwd=CHROME_SRC, env=env)
+    if return_code != 0:
+      return return_code
 

[Yaron, 2013/02/21 02:02:49]

Shouldn't it return 0 at the end if we reach it?

 
 if __name__ == '__main__':