Android buildbot - halt build if subcommand returns error

buildbot/bb_run_bot.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import json
 import optparse
 import os
@@ skipping 160 matching lines @@
   print 'Using config:', bot_config
 
   def CommandToString(command):
     """Returns quoted command that can be run in bash shell."""
     return ' '.join(map(pipes.quote, command))
 
   command_objs = GetCommands(options, bot_config)
   for command_obj in command_objs:
     print 'Will run:', CommandToString(command_obj.command)
 
-  return_code = 0
   for command_obj in command_objs:
     if command_obj.step_name:
       buildbot_report.PrintNamedStep(command_obj.step_name)
     command = command_obj.command
     print CommandToString(command)
     sys.stdout.flush()
     env = None
     if options.TESTING:
       # The bash command doesn't yet support the testing option.
       if command[0] == 'bash':
         continue
       env = dict(os.environ)
       env['BUILDBOT_TESTING'] = '1'
 
-    return_code |= subprocess.call(command, cwd=CHROME_SRC, env=env)
-  return return_code
+    return_code = subprocess.call(command, cwd=CHROME_SRC, env=env)
+    if return_code != 0:
+      return return_code
 

[Yaron, 2013/02/21 02:02:49]

Shouldn't it return 0 at the end if we reach it?

 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))