Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java

Issue 12324002: Drop TODO for getVmVersion method (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
index c922622fd4f02654db0962a441dba0778772c2a4..db00516d3a482a1e02116a24b954f8a466819edc 100644
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
@@ -33,10 +33,11 @@ public interface StandaloneVm extends JavascriptVm {
String getEmbedderName();
/**
+ * This version should correspond to {@link JavascriptVm#getVersion()}. However it gets available
+ * earlier, at the transport handshake stage.
* @return version of V8 implementation, format is unspecified; must not be null if
* {@link StandaloneVm} has been attached
*/
- // TODO: align this with {@link JavascriptVm#getVersion()} method.
String getVmVersion();
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698