Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java

Issue 12324002: Drop TODO for getVmVersion method (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.sdk; 5 package org.chromium.sdk;
6 6
7 import java.io.IOException; 7 import java.io.IOException;
8 8
9 import org.chromium.sdk.util.MethodIsBlockingException; 9 import org.chromium.sdk.util.MethodIsBlockingException;
10 10
(...skipping 15 matching lines...) Expand all
26 */ 26 */
27 void attach(DebugEventListener listener) 27 void attach(DebugEventListener listener)
28 throws IOException, UnsupportedVersionException, MethodIsBlockingException ; 28 throws IOException, UnsupportedVersionException, MethodIsBlockingException ;
29 29
30 /** 30 /**
31 * @return name of embedding application as it wished to name itself; might be null 31 * @return name of embedding application as it wished to name itself; might be null
32 */ 32 */
33 String getEmbedderName(); 33 String getEmbedderName();
34 34
35 /** 35 /**
36 * This version should correspond to {@link JavascriptVm#getVersion()}. Howeve r it gets available
37 * earlier, at the transport handshake stage.
36 * @return version of V8 implementation, format is unspecified; must not be nu ll if 38 * @return version of V8 implementation, format is unspecified; must not be nu ll if
37 * {@link StandaloneVm} has been attached 39 * {@link StandaloneVm} has been attached
38 */ 40 */
39 // TODO: align this with {@link JavascriptVm#getVersion()} method.
40 String getVmVersion(); 41 String getVmVersion();
41 42
42 /** 43 /**
43 * @return message explaining why VM is detached; may be null 44 * @return message explaining why VM is detached; may be null
44 */ 45 */
45 String getDisconnectReason(); 46 String getDisconnectReason();
46 } 47 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698