Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: Source/core/inspector/WorkerInspectorController.cpp

Issue 1232333002: Fix virtual/override/final usage in the rest of Source/core/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/WorkerConsoleAgent.h ('k') | Source/core/inspector/WorkerRuntimeAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/WorkerInspectorController.cpp
diff --git a/Source/core/inspector/WorkerInspectorController.cpp b/Source/core/inspector/WorkerInspectorController.cpp
index 8bd19b81b85d71af4e74d6e082b95b47fa9ff22c..fdc9b05540954ec3a546eb2c3fb35a2cb31c3b51 100644
--- a/Source/core/inspector/WorkerInspectorController.cpp
+++ b/Source/core/inspector/WorkerInspectorController.cpp
@@ -64,18 +64,18 @@ class PageInspectorProxy final : public InspectorFrontendChannel {
WTF_MAKE_FAST_ALLOCATED(PageInspectorProxy);
public:
explicit PageInspectorProxy(WorkerGlobalScope* workerGlobalScope) : m_workerGlobalScope(workerGlobalScope) { }
- virtual ~PageInspectorProxy() { }
+ ~PageInspectorProxy() override { }
private:
- virtual void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message) override
+ void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message) override
{
// Worker messages are wrapped, no need to handle callId.
m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageInspector(message->toJSONString());
}
- virtual void sendProtocolNotification(PassRefPtr<JSONObject> message) override
+ void sendProtocolNotification(PassRefPtr<JSONObject> message) override
{
m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageInspector(message->toJSONString());
}
- virtual void flush() override { }
+ void flush() override { }
WorkerGlobalScope* m_workerGlobalScope;
};
@@ -83,18 +83,18 @@ class WorkerStateClient final : public InspectorStateClient {
WTF_MAKE_FAST_ALLOCATED(WorkerStateClient);
public:
WorkerStateClient(WorkerGlobalScope* context) { }
- virtual ~WorkerStateClient() { }
+ ~WorkerStateClient() override { }
private:
- virtual void updateInspectorStateCookie(const String& cookie) override { }
+ void updateInspectorStateCookie(const String& cookie) override { }
};
class RunInspectorCommandsTask final : public InspectorTaskRunner::Task {
public:
explicit RunInspectorCommandsTask(WorkerThread* thread)
: m_thread(thread) { }
- virtual ~RunInspectorCommandsTask() { }
- virtual void run() override
+ ~RunInspectorCommandsTask() override { }
+ void run() override
{
// Process all queued debugger commands. WorkerThread is certainly
// alive if this task is being executed.
« no previous file with comments | « Source/core/inspector/WorkerConsoleAgent.h ('k') | Source/core/inspector/WorkerRuntimeAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698