Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1232313007: MIPS: Fix missing falthru handling for some branch cases in TF. (Closed)

Created:
5 years, 5 months ago by dusmil.imgtec
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix missing falthru handling for some branch cases in TF. TEST=mjsunit/asm/embenchen/zlib BUG= Committed: https://crrev.com/82339644b24eccad008335a8bcbcfcd6532823f0 Cr-Commit-Position: refs/heads/master@{#29735}

Patch Set 1 #

Patch Set 2 : Clean the code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +1 line, -11 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dusmil.imgtec
PTAL.
5 years, 5 months ago (2015-07-17 13:08:21 UTC) #2
Jakob Kummerow
mjsunit.status LGTM. Regarding the other changes: you have a 5-way if...else-if... sequence, where every block ...
5 years, 5 months ago (2015-07-17 13:14:04 UTC) #3
dusmil.imgtec
Right, thanks.
5 years, 5 months ago (2015-07-17 14:37:14 UTC) #4
paul.l...
LGTM.
5 years, 5 months ago (2015-07-17 15:32:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232313007/20001
5 years, 5 months ago (2015-07-17 15:36:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 15:59:35 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 15:59:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82339644b24eccad008335a8bcbcfcd6532823f0
Cr-Commit-Position: refs/heads/master@{#29735}

Powered by Google App Engine
This is Rietveld 408576698