Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232313002: Use package:sky imports consistently (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use package:sky imports consistently Apparently this style is recommended by Dart developers. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/425e8439c02b2173809ffee0e2edd6deb773504c

Patch Set 1 #

Patch Set 2 : fix BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -343 lines) Patch
M sky/sdk/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M sky/sdk/lib/animation/animated_simulation.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/animation/animation_performance.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/sdk/lib/animation/fling_curve.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/sdk/lib/animation/timeline.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/editing/editable_text.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/editing/input.dart View 2 chunks +7 lines, -7 lines 0 comments Download
D sky/sdk/lib/editing/keyboard.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M sky/sdk/lib/mojo/activity.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/mojo/asset_bundle.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + sky/sdk/lib/mojo/keyboard.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/mojo/net/fetch.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/mojo/net/image_cache.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/mojo/shell.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/painting/box_painter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/rendering/auto_layout.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/rendering/block.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/sdk/lib/rendering/box.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M sky/sdk/lib/rendering/flex.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/rendering/object.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M sky/sdk/lib/rendering/paragraph.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/rendering/sky_binding.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/rendering/stack.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/theme/shadows.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/theme/theme_data.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/theme/typography.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/animated_container.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/animation_builder.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 1 chunk +16 lines, -17 lines 0 comments Download
M sky/sdk/lib/widgets/block_viewport.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/button_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/card.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/default_text_style.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/dialog.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/fixed_height_scrollable.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/flat_button.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/icon.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/icon_button.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M sky/sdk/lib/widgets/material_button.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/menu_divider.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/modal_overlay.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/navigator.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu_item.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/sdk/lib/widgets/radio.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/scaffold.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable_list.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable_viewport.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/snack_bar.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/switch.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/task_description.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/theme.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/variable_height_scrollable.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-12 04:15:14 UTC) #1
abarth-chromium
Committed patchset #2 (id:20001) manually as 425e8439c02b2173809ffee0e2edd6deb773504c (presubmit successful).
5 years, 5 months ago (2015-07-12 04:38:31 UTC) #2
Hixie
RSLGTM
5 years, 5 months ago (2015-07-13 15:30:38 UTC) #3
Hixie
RSLGTM
5 years, 5 months ago (2015-07-13 15:30:38 UTC) #4
Hixie
5 years, 5 months ago (2015-07-13 15:30:39 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698