Rename LockBackForwardList to ReplaceCurrentItem.

Source/core/loader/FrameLoadRequest.h

Index: Source/core/loader/FrameLoadRequest.h
diff --git a/Source/core/loader/FrameLoadRequest.h b/Source/core/loader/FrameLoadRequest.h
index d9f63802c2c26345c314db1a1b2b2dbf82d37806..cf4a74a4ecd6a824753e6875a7ae9abafbaa6af8 100644
--- a/Source/core/loader/FrameLoadRequest.h
+++ b/Source/core/loader/FrameLoadRequest.h
@@ -41,7 +41,7 @@ struct FrameLoadRequest {
 public:
     explicit FrameLoadRequest(Document* originDocument)
         : m_originDocument(originDocument)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)

[Charlie Reis, 2015/07/10 22:51:14]

I went with "replaces" on the request object itself (where it reflects what the
request will do when it commits) vs "replace" in the places that it's used as a
command.  Sound reasonable, or should I use the same spelling everywhere?

[Nate Chapin, 2015/07/13 23:24:15]

It's sufficiently pedantic that I'm not confident others will use it correctly,
but I think it's fine to attempt it :)

         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
@@ -53,7 +53,7 @@ public:
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
@@ -66,7 +66,7 @@ public:
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_frameName(frameName)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
@@ -79,7 +79,7 @@ public:
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_frameName(frameName)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(shouldCheckMainWorldContentSecurityPolicy)
@@ -92,7 +92,7 @@ public:
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_substituteData(substituteData)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
@@ -111,8 +111,8 @@ public:
 
     const SubstituteData& substituteData() const { return m_substituteData; }
 
-    bool lockBackForwardList() const { return m_lockBackForwardList; }
-    void setLockBackForwardList(bool lockBackForwardList) { m_lockBackForwardList = lockBackForwardList; }
+    bool replacesCurrentItem() const { return m_replacesCurrentItem; }
+    void setReplacesCurrentItem(bool replacesCurrentItem) { m_replacesCurrentItem = replacesCurrentItem; }
 
     ClientRedirectPolicy clientRedirect() const { return m_clientRedirect; }
     void setClientRedirect(ClientRedirectPolicy clientRedirect) { m_clientRedirect = clientRedirect; }
@@ -133,7 +133,7 @@ private:
     ResourceRequest m_resourceRequest;
     AtomicString m_frameName;
     SubstituteData m_substituteData;
-    bool m_lockBackForwardList;
+    bool m_replacesCurrentItem;
     ClientRedirectPolicy m_clientRedirect;
     RefPtrWillBeMember<Event> m_triggeringEvent;
     RefPtrWillBeMember<HTMLFormElement> m_form;