Rename LockBackForwardList to ReplaceCurrentItem.

Source/core/loader/FrameLoadRequest.h

 /*
  * Copyright (C) 2003, 2006, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 23 matching lines @@
 #include "core/loader/FrameLoaderTypes.h"
 #include "platform/network/ResourceRequest.h"
 
 namespace blink {
 
 struct FrameLoadRequest {
     STACK_ALLOCATED();
 public:
     explicit FrameLoadRequest(Document* originDocument)
         : m_originDocument(originDocument)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)

[Charlie Reis, 2015/07/10 22:51:14]

I went with "replaces" on the request object itself (where it reflects what the
request will do when it commits) vs "replace" in the places that it's used as a
command.  Sound reasonable, or should I use the same spelling everywhere?

[Nate Chapin, 2015/07/13 23:24:15]

It's sufficiently pedantic that I'm not confident others will use it correctly,
but I think it's fine to attempt it :)

         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
     {
         if (originDocument)
             m_resourceRequest.setRequestorOrigin(SecurityOrigin::create(originDocument->url()));
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
     {
         if (originDocument)
             m_resourceRequest.setRequestorOrigin(SecurityOrigin::create(originDocument->url()));
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const AtomicString& frameName)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_frameName(frameName)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
     {
         if (originDocument)
             m_resourceRequest.setRequestorOrigin(SecurityOrigin::create(originDocument->url()));
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const AtomicString& frameName, ContentSecurityPolicyDisposition shouldCheckMainWorldContentSecurityPolicy)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_frameName(frameName)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(shouldCheckMainWorldContentSecurityPolicy)
     {
         if (originDocument)
             m_resourceRequest.setRequestorOrigin(SecurityOrigin::create(originDocument->url()));
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const SubstituteData& substituteData)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_substituteData(substituteData)
-        , m_lockBackForwardList(false)
+        , m_replacesCurrentItem(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
     {
         if (originDocument)
             m_resourceRequest.setRequestorOrigin(SecurityOrigin::create(originDocument->url()));
     }
 
     Document* originDocument() const { return m_originDocument.get(); }
 
     ResourceRequest& resourceRequest() { return m_resourceRequest; }
     const ResourceRequest& resourceRequest() const { return m_resourceRequest; }
 
     const AtomicString& frameName() const { return m_frameName; }
     void setFrameName(const AtomicString& frameName) { m_frameName = frameName; }
 
     const SubstituteData& substituteData() const { return m_substituteData; }
 
-    bool lockBackForwardList() const { return m_lockBackForwardList; }
-    void setLockBackForwardList(bool lockBackForwardList) { m_lockBackForwardList = lockBackForwardList; }
+    bool replacesCurrentItem() const { return m_replacesCurrentItem; }
+    void setReplacesCurrentItem(bool replacesCurrentItem) { m_replacesCurrentItem = replacesCurrentItem; }
 
     ClientRedirectPolicy clientRedirect() const { return m_clientRedirect; }
     void setClientRedirect(ClientRedirectPolicy clientRedirect) { m_clientRedirect = clientRedirect; }
 
     Event* triggeringEvent() const { return m_triggeringEvent.get(); }
     void setTriggeringEvent(PassRefPtrWillBeRawPtr<Event> triggeringEvent) { m_triggeringEvent = triggeringEvent; }
 
     HTMLFormElement* form() const { return m_form.get(); }
     void setForm(PassRefPtrWillBeRawPtr<HTMLFormElement> form) { m_form = form; }
 
     ShouldSendReferrer shouldSendReferrer() const { return m_shouldSendReferrer; }
     void setShouldSendReferrer(ShouldSendReferrer shouldSendReferrer) { m_shouldSendReferrer = shouldSendReferrer; }
 
     ContentSecurityPolicyDisposition shouldCheckMainWorldContentSecurityPolicy() const { return m_shouldCheckMainWorldContentSecurityPolicy; }
 
 private:
     RefPtrWillBeMember<Document> m_originDocument;
     ResourceRequest m_resourceRequest;
     AtomicString m_frameName;
     SubstituteData m_substituteData;
-    bool m_lockBackForwardList;
+    bool m_replacesCurrentItem;
     ClientRedirectPolicy m_clientRedirect;
     RefPtrWillBeMember<Event> m_triggeringEvent;
     RefPtrWillBeMember<HTMLFormElement> m_form;
     ShouldSendReferrer m_shouldSendReferrer;
     ContentSecurityPolicyDisposition m_shouldCheckMainWorldContentSecurityPolicy;
 };
 
 }
 
 #endif // FrameLoadRequest_h