Rename LockBackForwardList to ReplaceCurrentItem.

Rename LockBackForwardList to ReplaceCurrentItem.

This is more consistent with terminology we use in Chromium.

BUG=none
TEST=No behavior change.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198822

[Charlie Reis, 2015-07-10 22:51:13]

creis@chromium.org changed reviewers:
+ japhet@chromium.org

[Charlie Reis, 2015-07-10 22:51:14]

Nate, can you take a look?  As you mention, it'd be good to improve this name
before we start using it in Chromium in
https://codereview.chromium.org/1225593003/.

https://codereview.chromium.org/1232223002/diff/1/Source/core/loader/FrameLoa...
File Source/core/loader/FrameLoadRequest.h (right):

https://codereview.chromium.org/1232223002/diff/1/Source/core/loader/FrameLoa...
Source/core/loader/FrameLoadRequest.h:44: , m_replacesCurrentItem(false)
I went with "replaces" on the request object itself (where it reflects what the
request will do when it commits) vs "replace" in the places that it's used as a
command.  Sound reasonable, or should I use the same spelling everywhere?

https://codereview.chromium.org/1232223002/diff/1/Source/core/loader/Navigati...
File Source/core/loader/NavigationScheduler.cpp (right):

https://codereview.chromium.org/1232223002/diff/1/Source/core/loader/Navigati...
Source/core/loader/NavigationScheduler.cpp:74: ,
m_replacesCurrentItem(replacesCurrentItem)
Same here.

[Charlie Reis, 2015-07-13 23:22:00]

Friendly ping-- I'd like to land this before the location.replace fix.

[Nate Chapin, 2015-07-13 23:24:15]

LGTM. Thanks for doing this, and sorry for missing when you first sent this out.

https://codereview.chromium.org/1232223002/diff/1/Source/core/loader/FrameLoa...
File Source/core/loader/FrameLoadRequest.h (right):

https://codereview.chromium.org/1232223002/diff/1/Source/core/loader/FrameLoa...
Source/core/loader/FrameLoadRequest.h:44: , m_replacesCurrentItem(false)
On 2015/07/10 22:51:14, Charlie Reis wrote:
> I went with "replaces" on the request object itself (where it reflects what
the
> request will do when it commits) vs "replace" in the places that it's used as
a
> command.  Sound reasonable, or should I use the same spelling everywhere?

It's sufficiently pedantic that I'm not confident others will use it correctly,
but I think it's fine to attempt it :)

[Charlie Reis, 2015-07-13 23:29:20]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2015-07-13 23:30:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232223002/1

[commit-bot: I haz the power, 2015-07-14 00:58:40]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198822