Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1232163002: ovals now take a const GrPipelineBuilder (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@const-fix2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

ovals now take a const GrPipelineBuilder BUG=skia: Committed: https://skia.googlesource.com/skia/+/ae3d63ad906021b6ca27f0737addc62034457ff0

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 14 chunks +19 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-10 17:12:01 UTC) #2
robertphillips
lgtm
5 years, 5 months ago (2015-07-13 15:14:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232163002/20001
5 years, 5 months ago (2015-07-13 15:19:39 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:44:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ae3d63ad906021b6ca27f0737addc62034457ff0

Powered by Google App Engine
This is Rietveld 408576698