Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1228763005: small cleanups after fixing const of GrPipelineBuilder on DrawTarget (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@const-fix3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

small cleanups after fixing const of GrPipelineBuilder on DrawTarget Fuse AutoRestoreFragmentProcessors and AutoRestoreProcessorDataManager into new AutoRestoreFragmentProcessorState class BUG=skia: Committed: https://skia.googlesource.com/skia/+/4421a4c90df48931758cdb747d5be80edb56cd12

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 6

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -102 lines) Patch
M src/gpu/GrClipMaskManager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 8 chunks +18 lines, -20 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 5 chunks +10 lines, -16 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 2 4 chunks +18 lines, -51 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1232163002 Patch 20001

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-13 15:20:05 UTC) #2
robertphillips
lgtm + naming & doc requests https://codereview.chromium.org/1228763005/diff/20001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/1228763005/diff/20001/src/gpu/GrClipMaskManager.cpp#newcode34 src/gpu/GrClipMaskManager.cpp:34: GrTexture* result, arfps ...
5 years, 5 months ago (2015-07-13 16:16:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228763005/40001
5 years, 5 months ago (2015-07-13 16:29:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 16:36:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4421a4c90df48931758cdb747d5be80edb56cd12

Powered by Google App Engine
This is Rietveld 408576698