media/base/video_decoder.h - Issue 123213006: Make VideoDecoder use (kAborted, NULL) to signify an aborted decode, instead of (kOk, NULL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_decoder.h

Issue 123213006: Make VideoDecoder use (kAborted, NULL) to signify an aborted decode, instead of (kOk, NULL). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle aborted read status in VideoFrameStream. Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/video_decoder.h

diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h

index 63f63e5d7d6d9b70dc9f84c98fb159b2e7653df5..4ac847ff1fd84a423d100cefd4fc818f32123d94 100644

--- a/media/base/video_decoder.h

+++ b/media/base/video_decoder.h

@@ -22,6 +22,7 @@ class MEDIA_EXPORT VideoDecoder {

// Status codes for decode operations on VideoDecoder.

enum Status {

kOk, // Everything went as planned.

+ kAborted, // Decode was aborted.

xhwang 2014/01/03 01:05:58 Can we have something like: Decode was aborted as

kNotEnoughData, // Not enough data to produce a video frame.

kDecodeError, // Decoding error happened.

kDecryptError // Decrypting error happened.

« no previous file with comments | « no previous file | media/filters/decrypting_video_decoder.cc » ('j') | media/filters/ffmpeg_video_decoder_unittest.cc » ('J')