media/filters/ffmpeg_video_decoder_unittest.cc - Issue 123213006: Make VideoDecoder use (kAborted, NULL) to signify an aborted decode, instead of (kOk, NULL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_video_decoder_unittest.cc

Issue 123213006: Make VideoDecoder use (kAborted, NULL) to signify an aborted decode, instead of (kOk, NULL). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle aborted read status in VideoFrameStream. Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/ffmpeg_video_decoder_unittest.cc

diff --git a/media/filters/ffmpeg_video_decoder_unittest.cc b/media/filters/ffmpeg_video_decoder_unittest.cc

index 9663dd1360485d4fcee390667c53e641107c48f6..0b8d02284b6ce53f69aec4f1c9e6e3bbf2184795 100644

--- a/media/filters/ffmpeg_video_decoder_unittest.cc

+++ b/media/filters/ffmpeg_video_decoder_unittest.cc

@@ -149,6 +149,7 @@ class FFmpegVideoDecoderTest : public testing::Test {

case VideoDecoder::kNotEnoughData:

DCHECK(!frame);

continue;

+ case VideoDecoder::kAborted:

xhwang 2014/01/03 01:05:58 NOTREACHED()? The check on l.142 means that we sho

case VideoDecoder::kDecodeError:

case VideoDecoder::kDecryptError:

DCHECK(!frame);

« media/base/video_decoder.h ('K') | « media/filters/ffmpeg_video_decoder.cc ('k') | media/filters/video_frame_stream.cc » ('j') | media/filters/video_frame_stream.cc » ('J')