Issue 123213004: Function pointers -> templates in SkPictureFlat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 123213004: Function pointers -> templates in SkPictureFlat. (Closed)

Created:
6 years, 11 months ago by mtklein

Modified:
6 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Function pointers -> templates in SkPictureFlat. These flatten/unflatten function pointers were driving me nuts when reading the generated assembly for this code. We don't need the flexibility of function pointers here, so let's use templates to make it more manageable. You'll notice we get much better typing now on flatten/unflatten. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12873

Patch Set 1 #

Patch Set 2 : align storage #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -176 lines)			Patch
M	src/core/SkPictureFlat.h	View	1	7 chunks	+81 lines, -78 lines	0 comments	Download
M	src/core/SkPictureFlat.cpp	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	tests/BitmapHeapTest.cpp	View		1 chunk	+4 lines, -10 lines	0 comments	Download
M	tests/FlatDataTest.cpp	View		4 chunks	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/123213004/50001

6 years, 11 months ago (2014-01-02 21:49:30 UTC) #3

Message was sent while issue was closed.

Change committed as 12873

Expand Messages | Collapse Messages