Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1232123006: PPC: Debugger: record reloc info for debug break slot immediate before the slot. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch7
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Debugger: record reloc info for debug break slot immediate before the slot. Port 0a19e44925301b9c0a554bbec5e3fb5a6cd09efa Original commit message: If we do it too early, we might get a constant pool between the reloc info and the actual slot. R=yangguo@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/f91119c4554bdf30facb36fca0558d18e4589faf Cr-Commit-Position: refs/heads/master@{#29585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/ppc/debug-ppc.cc View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-10 20:52:53 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-10 20:53:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232123006/1
5 years, 5 months ago (2015-07-10 20:55:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2220) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 20:57:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232123006/1
5 years, 5 months ago (2015-07-10 21:04:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 21:27:41 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:27:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f91119c4554bdf30facb36fca0558d18e4589faf
Cr-Commit-Position: refs/heads/master@{#29585}

Powered by Google App Engine
This is Rietveld 408576698