Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1231173002: PPC: Debugger: use debug break slot to break on call. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Debugger: use debug break slot to break on call. Port 8965b683ce39bc3c24ed2466d189323d81a70852 Original commit message: Break point at calls are currently set via IC. To change this, we need to set debug break slots instead. We also need to distinguish those debug break slots as calls to support step-in. To implement this, we add a data field to debug break reloc info to indicate non-call debug breaks or in case of call debug breaks, the number of arguments. We can later use this to find the callee on the evaluation stack in Debug::PrepareStep. R=yangguo@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/16e5c248958fc2e68eae4dae33146331aca827d8 Cr-Commit-Position: refs/heads/master@{#29582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -79 lines) Patch
M src/ppc/assembler-ppc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/debug-ppc.cc View 6 chunks +14 lines, -74 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 6 chunks +6 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-10 20:34:19 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-10 20:37:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231173002/1
5 years, 5 months ago (2015-07-10 20:37:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 21:02:26 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:02:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16e5c248958fc2e68eae4dae33146331aca827d8
Cr-Commit-Position: refs/heads/master@{#29582}

Powered by Google App Engine
This is Rietveld 408576698