Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 12321140: cc: Check for cheap task completion sooner (Closed)

Created:
7 years, 10 months ago by Sami
Modified:
7 years, 9 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Check for cheap task completion sooner Instead of using the normal 6 ms period to poll for cheap task completion, do the check immediately after running a batch of cheap tasks. This improves cheap task completion latency. In order to avoid disturbing the scheduling of normal task completion, this optimization is only performed if there are no pending non-cheap tasks. BUG=178441 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185051

Patch Set 1 #

Patch Set 2 : Call OnIdle instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M cc/worker_pool.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sami
See https://code.google.com/p/chromium/issues/detail?id=178441 for some data about this patch.
7 years, 10 months ago (2013-02-26 17:50:37 UTC) #1
reveman
Are we just not missing a call to OnIdle? The worker pool is supposed to ...
7 years, 10 months ago (2013-02-26 20:43:09 UTC) #2
Sami
On 2013/02/26 20:43:09, David Reveman wrote: > Are we just not missing a call to ...
7 years, 9 months ago (2013-02-27 11:33:53 UTC) #3
reveman
lgtm
7 years, 9 months ago (2013-02-27 18:21:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/12321140/3
7 years, 9 months ago (2013-02-27 18:29:41 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-02-27 22:02:21 UTC) #6
Message was sent while issue was closed.
Change committed as 185051

Powered by Google App Engine
This is Rietveld 408576698