Chromium Code Reviews
Help | Chromium Project | Sign in
(816)

Issue 12321078: Make base64 decoding available in dart:crypto

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by drt24
Modified:
1 year ago
Reviewers:
mehmet akin <mdakin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make base64 decoding available in dart:crypto

Move the base64 decoding code from pkg/webdriver into dart:crypto and then
use dart:crypto in webdriver.
The version in dart:crypto has the additional feature of supporting line breaks
in base64 encoded strings and having more tests.

BUG=http://code.google.com/p/dart/issues/detail?id=2458

Patch Set 1 #

Patch Set 2 : Remove duplicate base64 decoding functionality from webdriver and use dart:crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -58 lines) Lint Patch
D pkg/webdriver/lib/src/base64decoder.dart View 1 1 chunk +0 lines, -55 lines 0 comments ? errors Download
M pkg/webdriver/lib/webdriver.dart View 1 2 chunks +2 lines, -3 lines 0 comments ? errors Download
Trybot results: Sign in to try more bots
Commit:

Issue must be closed to Revert

Messages

Total messages: 1
drt24
1 year, 1 month ago #1
dart:crypto has support for base64 encoding but not for base64 decoding. This
uses existing code moved from webdriver to do base64 decoding which seemed to be
the strategy recommended in: http://code.google.com/p/dart/issues/detail?id=2458

Daniel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6