Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 12321078: Make base64 decoding available in dart:crypto

Can't Edit
Can't Publish+Mail
Start Review
4 years, 7 months ago by drt24
11 months, 1 week ago
mehmet akin <mdakin


Make base64 decoding available in dart:crypto Move the base64 decoding code from pkg/webdriver into dart:crypto and then use dart:crypto in webdriver. The version in dart:crypto has the additional feature of supporting line breaks in base64 encoded strings and having more tests. BUG=

Patch Set 1 #

Patch Set 2 : Remove duplicate base64 decoding functionality from webdriver and use dart:crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -58 lines) Patch
D pkg/webdriver/lib/src/base64decoder.dart View 1 1 chunk +0 lines, -55 lines 0 comments Download
M pkg/webdriver/lib/webdriver.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).


Total messages: 1 (0 generated)
4 years, 7 months ago (2013-02-22 12:27:04 UTC) #1
dart:crypto has support for base64 encoding but not for base64 decoding. This
uses existing code moved from webdriver to do base64 decoding which seemed to be
the strategy recommended in:

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b