Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1232063005: [Media Router] Remove unnecessary CONTENT_EXPORT. (Closed)

Created:
5 years, 5 months ago by imcheng (use chromium acct)
Modified:
5 years, 5 months ago
Reviewers:
mark a. foltz, imcheng, Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove unnecessary CONTENT_EXPORT. BUG=504938 NOTRY=true TBR=mfoltz Committed: https://crrev.com/99c0c42ae1505d01cf0887bc74f164eb78750aeb Cr-Commit-Position: refs/heads/master@{#338377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/browser/presentation_session.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
imcheng
5 years, 5 months ago (2015-07-10 21:45:33 UTC) #2
Nico
lgtm, thanks!
5 years, 5 months ago (2015-07-10 21:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232063005/1
5 years, 5 months ago (2015-07-10 21:46:55 UTC) #5
imcheng
+mfoltz for OWNERS
5 years, 5 months ago (2015-07-10 21:56:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/77994)
5 years, 5 months ago (2015-07-10 21:59:22 UTC) #9
Nico
mfoltz, I put you as TBR as this is a build fix and a pretty ...
5 years, 5 months ago (2015-07-10 22:00:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232063005/1
5 years, 5 months ago (2015-07-10 22:03:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 22:09:19 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99c0c42ae1505d01cf0887bc74f164eb78750aeb Cr-Commit-Position: refs/heads/master@{#338377}
5 years, 5 months ago (2015-07-10 22:10:14 UTC) #14
imcheng
I sent out a fix for another issue (missing & in unit test): https://codereview.chromium.org/1230793010
5 years, 5 months ago (2015-07-10 23:10:33 UTC) #15
mark a. foltz
5 years, 5 months ago (2015-07-10 23:32:04 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698