Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1230793010: [Media Router] Fix typo in unit test (&& instead of &) (Closed)

Created:
5 years, 5 months ago by imcheng (use chromium acct)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, media-router+watch_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Fix typo in unit test (&& instead of &) TBR=kmarshall BUG=504938 Committed: https://crrev.com/278665e6ef82ec2dafae168f8aaea3b6c2b77775 Cr-Commit-Position: refs/heads/master@{#338417}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/media/router/presentation_session_state_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
imcheng
5 years, 5 months ago (2015-07-10 23:09:39 UTC) #2
Kevin M
5 years, 5 months ago (2015-07-10 23:12:05 UTC) #3
Steven Holte
This is breaking a bot http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20daisy%20Compile/builds/1860/steps/compile/logs/stdio So I'm just going to commit it. lgtm
5 years, 5 months ago (2015-07-11 00:39:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230793010/20001
5 years, 5 months ago (2015-07-11 00:40:21 UTC) #7
imcheng (use chromium acct)
Thanks. Sorry about the breakage.
5 years, 5 months ago (2015-07-11 00:40:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/78054)
5 years, 5 months ago (2015-07-11 00:48:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230793010/20001
5 years, 5 months ago (2015-07-11 00:50:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-11 01:14:38 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 01:15:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/278665e6ef82ec2dafae168f8aaea3b6c2b77775
Cr-Commit-Position: refs/heads/master@{#338417}

Powered by Google App Engine
This is Rietveld 408576698