Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1231973003: Subzero: Fix register encodings. (Closed)

Created:
5 years, 5 months ago by Jim Stichnoth
Modified:
5 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix register encodings. Specifically, we were ending up with Encoded_Reg_xmm0=0 yet Encoded_Reg_xmm1=10, Encoded_Reg_xmm2=11, etc. It's a mystery as to why this wasn't triggering any failures with filetype!=asm. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=728c1d400bbf92053e3a3fcf1292810277844670

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M src/IceInstX8632.def View 2 chunks +17 lines, -17 lines 0 comments Download
M src/IceRegistersX8632.h View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
https://codereview.chromium.org/1231973003/diff/1/src/IceRegistersX8632.h File src/IceRegistersX8632.h (right): https://codereview.chromium.org/1231973003/diff/1/src/IceRegistersX8632.h#newcode45 src/IceRegistersX8632.h:45: Encoded_##val = encode, The problem here is that with ...
5 years, 5 months ago (2015-07-14 23:36:35 UTC) #2
John
lgtm
5 years, 5 months ago (2015-07-15 00:33:09 UTC) #3
Jim Stichnoth
5 years, 5 months ago (2015-07-15 16:00:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
728c1d400bbf92053e3a3fcf1292810277844670 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698