Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1231933006: Use AnimatedContainer for card_collection.dart. (Closed)

Created:
5 years, 5 months ago by Matt Perry
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -32 lines) Patch
M sky/sdk/example/widgets/card_collection.dart View 5 chunks +21 lines, -25 lines 2 comments Download
M sky/sdk/lib/animation/animation_performance.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/animated_container.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Matt Perry
5 years, 5 months ago (2015-07-09 23:16:16 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1231933006/diff/1/sky/sdk/example/widgets/card_collection.dart File sky/sdk/example/widgets/card_collection.dart (right): https://codereview.chromium.org/1231933006/diff/1/sky/sdk/example/widgets/card_collection.dart#newcode132 sky/sdk/example/widgets/card_collection.dart:132: card = new Opacity(child: card, opacity: 1.0); It's ...
5 years, 5 months ago (2015-07-09 23:20:14 UTC) #4
Matt Perry
https://codereview.chromium.org/1231933006/diff/1/sky/sdk/example/widgets/card_collection.dart File sky/sdk/example/widgets/card_collection.dart (right): https://codereview.chromium.org/1231933006/diff/1/sky/sdk/example/widgets/card_collection.dart#newcode132 sky/sdk/example/widgets/card_collection.dart:132: card = new Opacity(child: card, opacity: 1.0); On 2015/07/09 ...
5 years, 5 months ago (2015-07-09 23:25:50 UTC) #5
Matt Perry
5 years, 5 months ago (2015-07-09 23:31:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0b232e9bf425408473cd02cbe202dcd27879a91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698