chrome/renderer/extensions/dispatcher.cc - Issue 12319073: Delete the extensions i18n message map when extension unload is received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 12319073: Delete the extensions i18n message map when extension unload is received. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed to i18n_apitest and fixed up misc Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/message_bundle.cc ('K') | « chrome/common/extensions/message_bundle.cc ('k') | chrome/test/data/extensions/api_test/i18nUpdate/_locales/en/messages.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/dispatcher.cc

diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc

index 930cb5d568e4bfc8812c9d484c4820e8c8efeaf5..89bb067067dc1f458f318148c53729e7939323ae 100644

--- a/chrome/renderer/extensions/dispatcher.cc

+++ b/chrome/renderer/extensions/dispatcher.cc

@@ -15,6 +15,7 @@

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/extensions/manifest.h"

+#include "chrome/common/extensions/message_bundle.h"

#include "chrome/common/extensions/permissions/permission_set.h"

#include "chrome/common/url_constants.h"

#include "chrome/common/view_type.h"

@@ -514,6 +515,10 @@ void Dispatcher::OnUnloaded(const std::string& id) {

v8_context_set_.OnExtensionUnloaded(id);

+ // Invalidates the messages map for the extension in case the extension is

+ // reloaded with a new messages map.

+ EraseL10nMessagesMap(id);

// We don't do anything with existing platform-app stylesheets. They will

// stay resident, but the URL pattern corresponding to the unloaded

// extension's URL just won't match anything anymore.